On 26/02/2019 16:20, Alvaro Herrera wrote:
> On 2019-Feb-23, John Naylor wrote:
>
>> On Fri, Feb 22, 2019 at 3:59 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>> The reason for not pushing much on making the test pass for
>>> nonstandard block sizes is that when I tried existing tests, there
>>> were already some failures.
>>
>> FWIW, I currently see 8 failures (attached).
>
> Hmm, not great -- even the strings test fails, which seems to try to handle
> the case explicitly. I did expect the plan shape ones to fail, but I'm
> surprised about the tablesample one.
>
The SYSTEM table sampling is basically per-page sampling so it depends
heavily on which rows are on which page.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services