Re: Add shared buffer hits to pg_stat_io

Hi,

On 3/9/23 2:23 PM, Melanie Plageman wrote:
> On Wed, Mar 8, 2023 at 2:23 PM Andres Freund <andres@anarazel.de> wrote:
>>
>> On 2023-03-08 13:44:32 -0500, Melanie Plageman wrote:
>>> However, I am concerned that, while unlikely, this could be flakey.
>>> Something could happen to force all of those blocks out of shared
>>> buffers (even though they were just read in) before we hit them.
>>
>> You could make the test query a simple nested loop self-join, that'll prevent
>> the page being evicted, because it'll still be pinned on the outer side, while
>> generating hits on the inner side.
> 
> Good idea. v3 attached.

Thanks! The added test looks good to me.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com