Re: Add RANGE with values and exclusions clauses to the WindowFunctions

On 2018-01-27 00:35, Oliver Ford wrote:
> Attached patch implements an extensible version of the RANGE with
> values clause. It doesn't actually add any more type support than was
[...]
> I've tested that the existing regression tests in previous versions
> still pass, and also added new tests for descending mode.
> 
> [0001-window-frame-v7.patch]

Hi,

Regression tests only succeed for assert-disabled compiles; they fail 
when assert-enabled:

I used (Centos 6.9):

./configure 
--prefix=/home/aardvark/pg_stuff/pg_installations/pgsql.frame_range 
--bindir=/home/aardvark/pg_stuff/pg_installations/pgsql.frame_range/bin 
--libdir=/home/aardvark/pg_stuff/pg_installations/pgsql.frame_range/lib 
--with-pgport=6977 --quiet --enable-depend --enable-cassert 
--enable-debug --with-openssl --with-perl --with-libxml --with-libxslt 
--with-zlib --enable-tap-tests  
--with-extra-version=_frame_range_20180127_0757_fb8697b31aae

make check:

[...]
      tsearch                  ... ok
      tsdicts                  ... ok
      foreign_data             ... ok
      window                   ... FAILED (test process exited with exit 
code 2)
      xmlmap                   ... ok
      functional_deps          ... ok
      advisory_lock            ... ok
      json                     ... ok
      jsonb                    ... ok
      json_encoding            ... ok
      indirect_toast           ... ok
      equivclass               ... ok
parallel group (19 tests):  copy2 plpgsql rowtypes with conversion limit 
without_oid rangefuncs plancache prepare sequence largeobject 
polymorphism xml temp domain truncate returning alter_table
      plancache                ... FAILED (test process exited with exit 
code 2)
      limit                    ... FAILED (test process exited with exit 
code 2)
      plpgsql                  ... FAILED (test process exited with exit 
code 2)
      copy2                    ... FAILED (test process exited with exit 
code 2)
      temp                     ... FAILED (test process exited with exit 
code 2)
      domain                   ... FAILED (test process exited with exit 
code 2)
      rangefuncs               ... FAILED (test process exited with exit 
code 2)
      prepare                  ... FAILED (test process exited with exit 
code 2)
      without_oid              ... FAILED (test process exited with exit 
code 2)
      conversion               ... FAILED (test process exited with exit 
code 2)
      truncate                 ... FAILED (test process exited with exit 
code 2)
      alter_table              ... FAILED (test process exited with exit 
code 2)
      sequence                 ... FAILED (test process exited with exit 
code 2)
      polymorphism             ... FAILED (test process exited with exit 
code 2)
      rowtypes                 ... FAILED (test process exited with exit 
code 2)
      returning                ... FAILED (test process exited with exit 
code 2)
      largeobject              ... FAILED (test process exited with exit 
code 2)
      with                     ... FAILED (test process exited with exit 
code 2)
      xml                      ... FAILED (test process exited with exit 
code 2)
parallel group (6 tests):  identity hash_part reloptions partition_join 
indexing partition_prune
      identity                 ... FAILED (test process exited with exit 
code 2)
      partition_join           ... FAILED (test process exited with exit 
code 2)
      partition_prune          ... FAILED (test process exited with exit 
code 2)
      reloptions               ... FAILED (test process exited with exit 
code 2)
      hash_part                ... FAILED (test process exited with exit 
code 2)
      indexing                 ... FAILED (test process exited with exit 
code 2)
test event_trigger            ... FAILED (test process exited with exit 
code 2)
test stats                    ... FAILED (test process exited with exit 
code 2)
============== shutting down postmaster               ==============

=========================
  28 of 186 tests failed.
=========================




thanks,

Erik Rijkers