Re: bms_prev_member won't work correctly if bitmapword is 64-bits

Поиск
Список
Период
Сортировка
От Teodor Sigaev
Тема Re: bms_prev_member won't work correctly if bitmapword is 64-bits
Дата
Msg-id c1147149-2969-d6b3-5649-e9416bba9c27@sigaev.ru
обсуждение исходный текст
Ответ на bms_prev_member won't work correctly if bitmapword is 64-bits  (David Rowley <david.rowley@2ndquadrant.com>)
Ответы Re: bms_prev_member won't work correctly if bitmapword is 64-bits  (David Rowley <david.rowley@2ndquadrant.com>)
Список pgsql-hackers
Thank you, pushed

David Rowley wrote:
> bms_prev_member mistakenly has a hardcoded 24 in the function. This
> should really be BITS_PER_BITMAPWORD - 8 so that it is properly set to
> 56 if someone compiles with 64-bit bitmapwords.
> 
> The attached fixes this and also adds a test to exercise the function
> a bit. [1] indicates there's currently no coverage of this function at
> all.
> 
> [1] https://coverage.postgresql.org/src/backend/nodes/bitmapset.c.gcov.html
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: wal_consistency_checking reports an inconsistency on masterbranch
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: minor fix for CloneRowTriggersToPartition