Re: [PATCH] Expose port->authn_id to extensions and triggers

Поиск
Список
Период
Сортировка
От Jacob Champion
Тема Re: [PATCH] Expose port->authn_id to extensions and triggers
Дата
Msg-id bbf2b922-4ff7-5c30-e3ef-2a8bdcdd1116@timescale.com
обсуждение исходный текст
Ответ на Re: [PATCH] Expose port->authn_id to extensions and triggers  ("Drouvot, Bertrand" <bdrouvot@amazon.com>)
Ответы Re: [PATCH] Expose port->authn_id to extensions and triggers
Список pgsql-hackers
On 8/23/22 01:53, Drouvot, Bertrand wrote:
> That sounds all good to me, except a typo for the author in the commit 
> message: s/Jocob/Jacob/

Thanks, I missed that on my readthrough! :D

Patch looks good to me, too, with one question:

> @@ -2688,6 +2689,7 @@ InitProcessGlobals(void)                                   
>     MyProcPid = getpid();                                                        
>     MyStartTimestamp = GetCurrentTimestamp();                                    
>     MyStartTime = timestamptz_to_time_t(MyStartTimestamp);                       
> +   memset(&MyClientConnectionInfo, 0, sizeof(MyClientConnectionInfo));          
>                                                                                  
>     /*                                                                           
>      * Set a different global seed in every process.  We want something 

When can we rely on static initialization, and when can't we? Is there a
concern that the memory could have been polluted from before the
postmaster's fork?

Thanks,
--Jacob



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Zhihong Yu
Дата:
Сообщение: Re: [BUG] parenting a PK constraint to a self-FK one (Was: Self FK oddity when attaching a partition)
Следующее
От: Zhihong Yu
Дата:
Сообщение: handling multiple matching constraints in DetachPartitionFinalize()