Re: Add PQsendSyncMessage() to libpq

Поиск
Список
Период
Сортировка
От Anton Kirilov
Тема Re: Add PQsendSyncMessage() to libpq
Дата
Msg-id b878b8d2-8481-4fde-a374-5ccb9168d4e4@gmail.com
обсуждение исходный текст
Ответ на Re: Add PQsendSyncMessage() to libpq  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: Add PQsendSyncMessage() to libpq  (Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>)
Re: Add PQsendSyncMessage() to libpq  (Jelte Fennema-Nio <postgres@jeltef.nl>)
Список pgsql-hackers
Hello,

Thanks for the feedback!

On 07/11/2023 09:23, Jelte Fennema-Nio wrote:
 > But I think it's looking at the situation from the wrong direction. 
[...] we should look at it as an addition to our current list of PQsend 
functions for a new packet type. And none of those PQsend functions ever 
needed a flag. Which makes sense, because they are the lowest level 
building blocks that make sense from a user perspective: They send a 
message type over the socket and don't do anything else.

Yes, I think that this is quite close to my thinking when I created the 
original version of the patch. Also, the protocol specification states 
that the Sync message lacks parameters.

Since there haven't been any comments from the other people who have 
chimed in on this e-mail thread, I will assume that there is consensus 
(we are doing a U-turn with the implementation approach after all), so 
here is the updated version of the patch.

Best wishes,
Anton Kirilov
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: proposal: possibility to read dumped table's name from file
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: pg_basebackup check vs Windows file path limits