Re: run pgindent on a regular basis / scripted manner

On 2023-01-23 Mo 05:44, Jelte Fennema wrote:
> I whipped up a pre-commit hook which automatically runs pgindent on the
> changed files in the commit. It won't add any changes automatically, but
> instead it fails the commit if it made any changes. That way you can add
> them manually if you want. Or if you don't, you can simply run git commit
> again without adding the changes. (or you can use the --no-verify flag of
> git commit to skip the hook completely)
>
> It did require adding some extra flags to pgindent. While it only required
> the --staged-only and --fail-on-changed flags, the --changed-only flag
> was easy to add and seemed generally useful.


Please see the changes to pgindent I committed about the same time I got
your email. I don't think we need your new flags, as it's possible (and
always has been) to provide pgindent with a list of files to be
indented. Instead of having pgindent run `git diff --name-only ...` the
git hook can do it and pass the results to pgindent in its command line.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com