Re: BUG #18866: Running pg_freespace() on views triggers an Abort

On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang wrote:

Your patch needs some adjustments. There is no need to include pg_class.h. I

don't like the proposed error message. I prefer saying the relation cannot be

opened because that's what will happen if it reaches this code path. This is an

existing message so no need for translation. The output will be like:

postgres=# SELECT pg_freespace('f', 0); 

ERROR:  cannot open relation "f"

DETAIL:  This operation is not supported for foreign tables.

postgres=# SELECT pg_freespace('pg_roles', 0); 

ERROR:  cannot open relation "pg_roles"

DETAIL:  This operation is not supported for views.

postgres=# SELECT pg_freespace('pg_class', 0); 

pg_freespace 

--------------

         7520

(1 row)

I'm attaching a patch that includes these modifications.