On 5/27/20 7:27 AM, David G. Johnston wrote:
> On Tuesday, May 26, 2020, David Rowley <dgrowleyml@gmail.com> wrote:
>
>> On Tue, 26 May 2020 at 23:59, Vik Fearing <vik@postgresfriends.org> wrote:
>>> Are you saying we should have all new EXPLAIN options off forever into
>>> the future because apps won't know about the new data? I guess we
>>> should also not ever introduce new plan nodes because those won't be
>>> known either.
>>
>> Another argument against this is that it creates dependency among the
>> new GUCs. Many of the options are not compatible with each other. e.g.
>>
>> postgres=# explain (timing on) select 1;
>> ERROR: EXPLAIN option TIMING requires ANALYZE
>>
>> Would you propose we just error out in that case, or should we
>> silently enable the required option, or disable the conflicting
>> option?
>>
>>
> The same thing we do today...ignore options that require analyze if analyze
> is not specified. There are no other options documented that are dependent
> with options besides than analyze. The docs say timing defaults to on, its
> only when explicitly specified instead of being treated as a default that
> the user message appears. All the GUCs are doing is changing the default.
Yes, the patch handles this case the way you describe. In fact, the
patch doesn't (or shouldn't) change any behavior at all.
--
Vik Fearing