Re: Improve prep_buildtree

On 30.07.25 12:58, Nazir Bilal Yavuz wrote:
> Hi,
> 
> On Wed, 30 Jul 2025 at 12:32, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> On 30.07.25 10:28, Nazir Bilal Yavuz wrote:
>>> On Wed, 30 Jul 2025 at 11:07, Peter Eisentraut <peter@eisentraut.org> wrote:
>>>>
>>>> To fix this, I first tried to devise a way to detect whether a given
>>>> directory is a build directory.  But that seemed pretty complicated.
>>>> Instead, I chose the simpler solution that we just enumerate the source
>>>> subdirectories that we know about (config, contrib, doc, src).  That way
>>>> we can also remove the special handling to exclude the .git directory
>>>> and make the find command a bit simpler.
>>>
>>> Meson looks for ${builddir}/meson-private/coredata.dat file to
>>> understand if the directory is a build directory [1]. I am just
>>> wondering if you tried this and found it complicated or did you try
>>> something else.
>>
>> I tried things along this line, but it's not easy to have a shell "find"
>> command handle that kind of logic.
> 
> That makes sense. I noticed one difference, patched prep_buildtree
> does not create a symbolic link for the top Makefile in the builddir.

Ok, here is an updated version that takes care of that, too.