Re: [bugfix] DISCARD ALL does not release advisory locks

Поиск
Список
Период
Сортировка
От Merlin Moncure
Тема Re: [bugfix] DISCARD ALL does not release advisory locks
Дата
Msg-id b42b73150811261041q5d61471at5d2353c95f760de@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [bugfix] DISCARD ALL does not release advisory locks  ("Marko Kreen" <markokr@gmail.com>)
Ответы Re: [bugfix] DISCARD ALL does not release advisory locks  ("Robert Haas" <robertmhaas@gmail.com>)
Re: [bugfix] DISCARD ALL does not release advisory locks  (Gregory Stark <stark@enterprisedb.com>)
Список pgsql-hackers
On Wed, Nov 26, 2008 at 11:06 AM, Marko Kreen <markokr@gmail.com> wrote:
>
> I think this should be back-patched as well:
>
> - The fact that disconnect will clean up used resources has been
>  always true, thus most clients assume at some level.
>
> - DISCARD ALL was new feature in 8.3.  It is highly doubtful some
>  adv-locks using project has managed to hard-code dependency on
>  buggy behaviour of DISCARD.
>
> - The bug was reported by regular user who encountered deadlocks
>  on 8.3 because of it.

I see your point but there's a pretty high standard for changing
existing behavior in bugfix releases. It's just as likely to introduce
an application bug as to fix one...suppose the application is using
both 'discard all' for prepared statements and advisory locks for
other purposes.  You could break that application.

merlin


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Windowing Function Patch Review -> Standard Conformance
Следующее
От: Steve Crawford
Дата:
Сообщение: Re: What's going on with pgfoundry?