On 11/10/2016 06:27 AM, Andreas Karlsson wrote:
> On 11/10/2016 05:29 AM, Peter Eisentraut wrote:
>> On 11/8/16 6:43 PM, Andreas Karlsson wrote:
>>> - Shouldn't last_value be NULL directly after we have created the
>>> sequence but nobody has called nextval() yet?
>>>
>>> - I noticed that last_value includes the cached values, but that also
>>> seems to me like the correct thing to do.
>>
>> The documentation now emphasizes that this is the value stored on disk.
>> This matches what Oracle does.
>
> We also store is_called on disk, I think that if is_called is false then
> last_value should be NULL. Either that or we should add is_called.
>
> I will give the patch another review some time this week when i can find
> the time.
Other than my comment above about is_called and last_value I think the
patch looks great.
Andreas