On 21.04.23 19:00, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> On 20.04.23 17:33, Andres Freund wrote:
>>> Peter, it's unlikely given the timeframe, but do you happen to remember why
>>> you specified -x when stripping static libs?
>
>> I suspect this was copied from GNU Libtool. Libtool still has that but
>> later changed the stripping of static libraries on darwin to "strip -S".
>> Maybe should adopt that.
>
> I tried that, but it seems strictly worse on output file size:
>
> $ ll lib*/libpq.a
> -rw-r--r-- 1 tgl staff 715312 Apr 21 12:52 lib-no-strip/libpq.a
> -rw-r--r-- 1 tgl staff 209984 Apr 21 12:51 lib-strip-S/libpq.a
> -rw-r--r-- 1 tgl staff 208456 Apr 21 12:50 lib-strip-x/libpq.a
> $ ll lib*/libecpg.a
> -rw-r--r-- 1 tgl staff 324952 Apr 21 12:52 lib-no-strip/libecpg.a
> -rw-r--r-- 1 tgl staff 102752 Apr 21 12:51 lib-strip-S/libecpg.a
> -rw-r--r-- 1 tgl staff 102088 Apr 21 12:50 lib-strip-x/libecpg.a
>
> If you use both -x and -S, you get the same file sizes as with -x
> alone. Not sure why we should change anything here.
The complaint was that -x doesn't work correctly, no?