Re: psql - add SHOW_ALL_RESULTS option

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: psql - add SHOW_ALL_RESULTS option
Дата
Msg-id alpine.DEB.2.22.394.2201040851220.3857182@pseudo
обсуждение исходный текст
Ответ на Re: psql - add SHOW_ALL_RESULTS option  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Ответы Re: psql - add SHOW_ALL_RESULTS option  (Fabien COELHO <coelho@cri.ensmp.fr>)
Список pgsql-hackers
Hello Peter,

> With this "voluntary crash", the regression test output is now
>
>     psql                         ... ok     (test process exited with exit 
> code 2)      281 ms
>
> Normally, I'd expect this during development if there was a crash somewhere, 
> but showing this during a normal run now, and moreover still saying "ok",

Well, from a testing perspective, the crash is voluntary and it is 
indeed ok:-)

> is quite weird and confusing.  Maybe this type of test should be done in 
> the TAP framework instead.

It could. Another simpler option: add a "psql_voluntary_crash.sql" with 
just that test instead of modifying the "psql.sql" test script? That would 
keep the test exit code information, but the name of the script would make 
things clearer?

Also, if non zero status do not look so ok, should they be noted as bad?

-- 
Fabien.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Rushabh Lathia
Дата:
Сообщение: Re: Per-table storage parameters for TableAM/IndexAM extensions
Следующее
От: Alexander Lakhin
Дата:
Сообщение: Re: Proposal: remove obsolete hot-standby testing infrastructure