Re: psql - add SHOW_ALL_RESULTS option
| От | Fabien COELHO |
|---|---|
| Тема | Re: psql - add SHOW_ALL_RESULTS option |
| Дата | |
| Msg-id | alpine.DEB.2.22.394.2106121130400.4105466@pseudo обсуждение исходный текст |
| Ответ на | Re: psql - add SHOW_ALL_RESULTS option (Peter Eisentraut <peter.eisentraut@enterprisedb.com>) |
| Ответы |
Re: psql - add SHOW_ALL_RESULTS option
Re: psql - add SHOW_ALL_RESULTS option |
| Список | pgsql-hackers |
Hello Peter, >> My overly naive trust in non regression test to catch any issues has been >> largely proven wrong. Three key features do not have a single tests. Sigh. >> >> I'll have some time to look at it over next week-end, but not before. > > I have reverted the patch and moved the commit fest entry to CF 2021-07. Attached a v7 which fixes known issues. I've tried to simplify the code and added a few comments. I've moved query cancellation reset in one place in SendQuery. I've switched to an array of buffers for notices, as suggested by Tom. The patch includes basic AUTOCOMMIT and ON_ERROR_ROLLBACK tests, which did not exist before, at all. I tried cancelling queries manually, but did not develop a test for this, mostly because last time I submitted a TAP test about psql to raise its coverage it was rejected. As usual, what is not tested does not work… -- Fabien.
Вложения
В списке pgsql-hackers по дате отправления: