Re: refactoring - share str2*int64 functions

Hello Thomas,

> On Mon, Jul 15, 2019 at 5:08 PM Fabien COELHO  wrote:
>> The compromise I can offer is to change the name of the first one, say to
>> "pg_scanint8" to reflect its former backend name. Attached a v4 which does
>> a renaming so as to avoid the name similarity but signature difference. I
>> also made both error messages identical.
>
> Cool.  I'm not exactly sure when we should include 'pg_' in identifier
> names.  It seems to be used for functions/macros that wrap or replace
> something else with a similar name, like pg_pwrite(),
> pg_attribute_noreturn(), ...  In this case it's just our own code that
> we're moving, so I'm wondering if we should just call it scanint8().

I added the pg_ prefix as a poor man's namespace because the function can 
be used by external tools (eg contribs), so as to avoid potential name 
conflicts.

I agree that such conflicts are less probable if the name does not replace 
something existing.

> If you agree, I think this is ready to commit.

It can be removed, or not. So you do as you feel.

-- 
Fabien.