Re: [PATCH] Implement uuid_version()
От | Fabien COELHO |
---|---|
Тема | Re: [PATCH] Implement uuid_version() |
Дата | |
Msg-id | alpine.DEB.2.21.1907130816430.8895@lancre обсуждение исходный текст |
Ответ на | Re: [PATCH] Implement uuid_version() (Jose Luis Tallon <jltallon@adv-solutions.net>) |
Ответы |
Re: [PATCH] Implement uuid_version()
|
Список | pgsql-hackers |
Hello Jose, > Got it, and done. Please find attached a v2 patch with the upgrade script > included. Patch v2 applies cleanly. Compiles cleanly (once running configure --with-uuid=...). Local make check ok. Doc build ok. There are no tests, I'd suggest to add some under sql & change expected if possible which would return all possible values, including with calling pg_random_uuid() which should return 4. Documentation describes uuid_version(), should it not describe uuid_version(namespace uuid)? I'd suggest to add an example. The extension update script seems ok, but ISTM that "uuid-ossp-1.1.sql" should be replaced with an updated "uuid-ossp-1.2.sql". -- Fabien.
В списке pgsql-hackers по дате отправления: