Re: [PATCH v1] Add \echo_stderr to psql

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: [PATCH v1] Add \echo_stderr to psql
Дата
Msg-id alpine.DEB.2.21.1904271151260.29865@lancre
обсуждение исходный текст
Ответ на Re: [PATCH v1] Add \echo_stderr to psql  (David Fetter <david@fetter.org>)
Ответы Re: [PATCH v1] Add \echo_stderr to psql  (David Fetter <david@fetter.org>)
Список pgsql-hackers
Hello David,

> Please find attached v2, name is now \warn.

Patch applies cleanly, compiles, "make check ok", although there are no 
tests. Doc gen ok.

Code is pretty straightforward.

I'd put the commands in alphabetical order (echo, qecho, warn) instead of 
e/w/q in the condition.

The -n trick does not appear in the help lines, ISTM that it could fit, so 
maybe it could be added, possibly something like:

  \echo [-n] [TEXT]  write string to stdout, possibly without trailing newline

and same for \warn and \qecho?

> How might we test this portably?

Hmmm... TAP tests are expected to be portable. Attached a simple POC, 
which could be extended to test many more things which are currently out 
of coverage (src/bin/psql stuff is covered around 40% only).

-- 
Fabien.
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: Identity columns should own only one sequence
Следующее
От: Tom Lane
Дата:
Сообщение: Re: clean up docs for v12