Re: [PATCH v1] Show whether tables are logged in \dt+

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: [PATCH v1] Show whether tables are logged in \dt+
Дата
Msg-id alpine.DEB.2.21.1904240949080.27327@lancre
обсуждение исходный текст
Ответ на Re: [PATCH v1] Show whether tables are logged in \dt+  (David Fetter <david@fetter.org>)
Ответы Re: [PATCH v1] Show whether tables are logged in \dt+  (Rafia Sabih <rafia.pghackers@gmail.com>)
Список pgsql-hackers
Hello David,

>>> I noticed that there wasn't a bulk way to see table logged-ness in psql,
>>> so I made it part of \dt+.
>>
>> Applies, compiles, works for me.
>>
>> ISTM That temporary-ness is not shown either. Maybe the persistence column
>> should be shown as is?
>
> Temporariness added, but not raw.

Ok, it is better like this way.

>> Tests?
>
> Included, but they're not stable for temp tables. I'm a little stumped
> as to how to either stabilize them or test some other way.

Hmmm. First there is the username which appears, so there should be a 
dedicated user for the test.

I'm unsure how to work around the temporary schema number, which is 
undeterministic with parallel execution it. I'm afraid the only viable 
approach is not to show temporary tables, too bad:-(

>> Doc?
>
> What further documentation does it need?

Indeed, there is no precise doc, so nothing to update :-)/:-(


Maybe you could consider adding a case for prior 9.1 version, something 
like:
   ... case c.relistemp then 'temporary' else 'permanent' end as ...

-- 
Fabien.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: standby recovery fails (tablespace related) (tentative patchand discussion)
Следующее
От: Etsuro Fujita
Дата:
Сообщение: Re: bug in update tuple routing with foreign partitions