Re: pgsql: Fix memory leak in pgbench

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: pgsql: Fix memory leak in pgbench
Дата
Msg-id alpine.DEB.2.21.1904100810560.19300@lancre
обсуждение исходный текст
Ответ на Re: pgsql: Fix memory leak in pgbench  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-committers
Bonjour Michaël,

>> This change leads a compiler warning on my machine:
>>
>> pgbench.c: In function ‘readCommandResponse’:
>> pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code
>
> C99 does not forbid that (see d9dd406).

https://www.postgresql.org/docs/devel/source-conventions.html also says:

"A few features included in the C99 standard are, at this time, not be 
permitted to be used in core PostgreSQL code. This currently includes 
variable length arrays, intermingled declarations and code, // comments, 
universal character names. Reasons for that include portability and 
historical practices."

-- 
Fabien.

В списке pgsql-committers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: Fix memory leak in pgbench
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: pgsql: Fix memory leak in pgbench