Re: pgsql: Fix memory leak in pgbench

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: pgsql: Fix memory leak in pgbench
Дата
Msg-id alpine.DEB.2.21.1904100800060.19300@lancre
обсуждение исходный текст
Ответ на Re: pgsql: Fix memory leak in pgbench  (Masahiko Sawada <sawada.mshk@gmail.com>)
Ответы Re: pgsql: Fix memory leak in pgbench  (Masahiko Sawada <sawada.mshk@gmail.com>)
Список pgsql-committers
Hello Masahiko-san,

> This change leads a compiler warning on my machine:
>
> pgbench.c: In function ‘readCommandResponse’:
> pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code

<https://www.postgresql.org/docs/devel/source-conventions.html> says:

"Code in PostgreSQL should only rely on language features available in the 
C99 standard"

So it should be all right wrt to warnings.

However the pg style in the same page says that intermingling decl & code 
is not permitted, so the proposed patch should be applied.

-- 
Fabien.

В списке pgsql-committers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: pgsql: Fix memory leak in pgbench
Следующее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: Fix memory leak in pgbench