Re: pgsql: Fix memory leak in pgbench

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: pgsql: Fix memory leak in pgbench
Дата
Msg-id alpine.DEB.2.21.1904091919180.19300@lancre
обсуждение исходный текст
Ответ на pgsql: Fix memory leak in pgbench  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: pgsql: Fix memory leak in pgbench  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список pgsql-committers
Hello Alvaro,

> Fix memory leak in pgbench

> Commit 25ee70511ec2 introduced a memory leak in pgbench: some PGresult
> structs were not being freed during error bailout, because we're now
> doing more PQgetResult() calls than previously.

Indeed, I did not consider cleaning up on errors when removing cset, and 
if errors are handled somehow it would have caused a problem.

Thanks for the fix. I could have prepared a patch if told that there was 
some problem, but it seems that pg coverity reports are private.

-- 
Fabien.



В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Fix typo
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: pgsql: Fix memory leak in pgbench