Re: pg_dump multi VALUES INSERT
| От | Fabien COELHO |
|---|---|
| Тема | Re: pg_dump multi VALUES INSERT |
| Дата | |
| Msg-id | alpine.DEB.2.21.1901230959220.16643@lancre обсуждение исходный текст |
| Ответ на | Re: pg_dump multi VALUES INSERT (David Rowley <david.rowley@2ndquadrant.com>) |
| Ответы |
Re: pg_dump multi VALUES INSERT
|
| Список | pgsql-hackers |
Hello David & Surafel, About this v10: Patch applies and compiles cleanly, local & global "make check" ok. A few comments, possibly redundant with some already in the thread. Out of abc-order rows-per-inserts option in getopt struct. help string does not specify the expected argument. I still think that the added rows_per_insert field is useless, ISTM That "int dump_inserts" can be reused, and you could also drop boolean got_rows_per_insert. The feature is not tested anywhere. I still think that there should be a test on empty/small/larger-than-rows-per-insert tables, possibly added to existing TAP-tests. -- Fabien.
В списке pgsql-hackers по дате отправления: