Re: fix psql \conninfo & \connect when using hostaddr

Поиск
Список
Период
Сортировка
Искать
От
Fabien COELHO
Тема
Re: fix psql \conninfo & \connect when using hostaddr
Дата
Msg-id
alpine.DEB.2.21.1811192036380.4640@lancre
Ответ на
Список
Дерево обсуждения
fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Noah Misch <noah@leadboat.com>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Dmitry Dolgov <9erthalion6@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Dmitry Dolgov <9erthalion6@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Noah Misch <noah@leadboat.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Noah Misch <noah@leadboat.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Michael Paquier <michael@paquier.xyz>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Noah Misch <noah@leadboat.com>
Re: fix psql \conninfo & \connect when using hostaddr Michael Paquier <michael@paquier.xyz>
Re: fix psql \conninfo & \connect when using hostaddr Dmitry Dolgov <9erthalion6@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Robert Haas <robertmhaas@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Pavel Stehule <pavel.stehule@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Arthur Zakirov <a.zakirov@postgrespro.ru>
Re: fix psql \conninfo & \connect when using hostaddr Pavel Stehule <pavel.stehule@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Arthur Zakirov <a.zakirov@postgrespro.ru>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Tom Lane <tgl@sss.pgh.pa.us>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Michael Paquier <michael@paquier.xyz>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <fabien.coelho@mines-paristech.fr>

Hello Alvaro,

>>  - libpq internal function getHostaddr get a length,
>>    and I added an assert about it.
>>  - added a few braces on if/if/else/if/else/else
>>  - added an UNKNOWN_HOST macro to hide "???"
>>  - moved host_addr[] declaration earlier to avoid some braces
>
> You forgot to free(conn->connip) during freePGconn().

Argh, indeed:-(

> I found the UNKNOWN_HOST business quite dubious -- not only in your
> patch but also in the existing coding.

So did I:-) I only kept it because it was already done like that.

> I changed the getHostname API so that instead of returning "???" it sets 
> the output buffer to the empty string.

I hesitated to do exactly that. I'm fine with that.

Thanks for the push.

-- 
Fabien.

В списке pgsql-hackers по дате отправления
От: Alvaro Herrera
Дата:
От: Fabien COELHO
Дата:
FAQ