Re: fix psql \conninfo & \connect when using hostaddr

Поиск
Список
Период
Сортировка
Искать
От
Fabien COELHO
Тема
Re: fix psql \conninfo & \connect when using hostaddr
Дата
Msg-id
alpine.DEB.2.21.1811171703090.16105@lancre
Ответ на
Список
Дерево обсуждения
fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Noah Misch <noah@leadboat.com>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Dmitry Dolgov <9erthalion6@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Dmitry Dolgov <9erthalion6@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Noah Misch <noah@leadboat.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Noah Misch <noah@leadboat.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Michael Paquier <michael@paquier.xyz>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Noah Misch <noah@leadboat.com>
Re: fix psql \conninfo & \connect when using hostaddr Michael Paquier <michael@paquier.xyz>
Re: fix psql \conninfo & \connect when using hostaddr Dmitry Dolgov <9erthalion6@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Robert Haas <robertmhaas@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Pavel Stehule <pavel.stehule@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Arthur Zakirov <a.zakirov@postgrespro.ru>
Re: fix psql \conninfo & \connect when using hostaddr Pavel Stehule <pavel.stehule@gmail.com>
Re: fix psql \conninfo & \connect when using hostaddr Arthur Zakirov <a.zakirov@postgrespro.ru>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Tom Lane <tgl@sss.pgh.pa.us>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Michael Paquier <michael@paquier.xyz>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <coelho@cri.ensmp.fr>
Re: fix psql \conninfo & \connect when using hostaddr Alvaro Herrera <alvherre@2ndquadrant.com>
Re: fix psql \conninfo & \connect when using hostaddr Fabien COELHO <fabien.coelho@mines-paristech.fr>

>> I'm working on improving the patch.
>
> Cool.

Here is the updated v2

  - libpq internal function getHostaddr get a length,
    and I added an assert about it.
  - added a few braces on if/if/else/if/else/else
  - added an UNKNOWN_HOST macro to hide "???"
  - moved host_addr[] declaration earlier to avoid some braces
  - I have not refactored psql connection message,
    but finally agree with Pavel & you have a point.

-- 
Fabien.
В списке pgsql-hackers по дате отправления
От: Fabien COELHO
Дата:
От: Justin Pryzby
Дата:
Сообщение: Re: pg11.1 jit segv
FAQ