RE: BUG #15228: pgbench custom script numbering off-by-one
| От | Fabien COELHO |
|---|---|
| Тема | RE: BUG #15228: pgbench custom script numbering off-by-one |
| Дата | |
| Msg-id | alpine.DEB.2.21.1806060410540.10347@lancre обсуждение исходный текст |
| Ответ на | RE: BUG #15228: pgbench custom script numbering off-by-one (Steven Winfield <Steven.Winfield@cantabcapital.com>) |
| Список | pgsql-bugs |
Hello Steven, There were some hesitations when developing this feature for 9.6, with a transition from starting from 0 to 1 on submission v9, without clear outside input in the discussion to which was better, if any. The rational for starting from 1 in the stdout report is that I felt, and still feel, that it is more user/human friendly this way. The 0-numbering for the log was pre-existing and as tools/scripts exist to process that, changing it is best avoided, and it is for machines anyway. So my 0.02€: IMO the minimum fuss is to let it as a feature, which it is, and just explicitely document it, so I'm on Tom's line here. See attached patch as an attempt to do that. Could be backpatched up to 9.6. I could also be okay with starting from 0 as well, sure, but I like human-friendlyness so I would not bother. >> So possibly we could resolve it by using 0-based numbering in the >> human-readable output, but that would confuse things too perhaps. >> >> Maybe we should just document it. > > Changing the human readable log, plus documentation, might be fair game > for a new major version. If so, I think the only changes required are: Sure. -- Fabien.
Вложения
В списке pgsql-bugs по дате отправления: