Re: [PATCH] pgbench - refactor some connection finish/null intocommon function

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: [PATCH] pgbench - refactor some connection finish/null intocommon function
Дата
Msg-id alpine.DEB.2.20.1801301233220.22080@lancre
обсуждение исходный текст
Ответ на [PATCH] pgbench - refactor some connection finish/null into commonfunction  ("Rady, Doug" <radydoug@amazon.com>)
Ответы Re: [PATCH] pgbench - refactor some connection finish/null intocommon function
Список pgsql-hackers
Дерево обсуждения 
Hello Doug,

> This patch refactors all of the connection state PQfinish() and NULL’ing into a single function.
> Excludes PQfinish() in doConnect().

My 0.02€:

The argument could be "PGconn **" instead of a "CState *"?
If so, it may be used in a few more places. What is your opinion?

I'm fine with this kind of factorization which takes out a three-line 
pattern, but I'm wondering whether it would please committers.

-- 
Fabien.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Oliver Ford
Дата:
Сообщение: Re: Add RANGE with values and exclusions clauses to the Window Functions
Следующее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: [HACKERS] path toward faster partition pruning