Re: [HACKERS] psql: new help related to variables are not tooreadable

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: [HACKERS] psql: new help related to variables are not tooreadable
Дата
Msg-id alpine.DEB.2.20.1709132051000.8924@lancre
обсуждение исходный текст
Ответ на Re: [HACKERS] psql: new help related to variables are not too readable  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] psql: new help related to variables are not too readable  ("David G. Johnston" <david.g.johnston@gmail.com>)
Список pgsql-hackers
Hello Tom,

>> Probably it needs some rebase after Tom committed result status variables.
>
>> As it is a style thing, ISTM that the patch is ready if most people agree
>> that it is better this way and there is no strong veto against.
>
> FWIW, I think it's a bad idea.  We already nearly-doubled the vertical
> space required for this variable list.  That was a heavy cost --- and we
> already got at least one complaint about it --- but it seemed warranted
> to avoid having to deal with very constrained variable descriptions.
> This proposes to make the vertical space nearly triple what it was in v10.
> In a typical-size window that's going to have a pretty severe impact on
> how much of the list you can see at once.  And the readability gain is
> (at least to my eyes) very marginal.

Ok, you do not like it. As Pavel said, it is subjective. When it is a 
matter of taste, people tend to differ, someone will always complain, one 
way or another, and they are neither right nor wrong.

So, is it a -1 or a veto?

If it is the later, the patch can be marked as "Rejected" and everybody 
will get more time for other things:-)

If it is a not a veto, people can continue to give their opinions. 
Personnally I'm fine with a pager, so vertical spacing is fine. I just do 
not like paging horizontally.

-- 
Fabien.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pierre Ducroquet
Дата:
Сообщение: Re: [HACKERS] Small patch for pg_basebackup argument parsing
Следующее
От: Jeff Janes
Дата:
Сообщение: [HACKERS] uninterruptible state in 10beta4