Re: [HACKERS] merge psql ef/ev sf/sv handling functions
| От | Fabien COELHO |
|---|---|
| Тема | Re: [HACKERS] merge psql ef/ev sf/sv handling functions |
| Дата | |
| Msg-id | alpine.DEB.2.20.1709070716120.17848@lancre обсуждение исходный текст |
| Ответ на | Re: [HACKERS] merge psql ef/ev sf/sv handling functions (Tom Lane <tgl@sss.pgh.pa.us>) |
| Список | pgsql-hackers |
> you can't do this sort of thing:
>
> - psql_error("The server (version %s) does not support editing function source.\n",
> + psql_error("The server (version %s) does not support editing %s.\n",
> formatPGVersionNumber(pset.sversion, false,
> - sverbuf, sizeof(sverbuf)));
> + sverbuf, sizeof(sverbuf)),
> + is_func ? "function source" : "view definitions");
>
> It's too much of a pain in the rear for translators.
Argh, indeed, I totally forgot about translations. Usually there is a _()
hint for gettext.
> See
> https://www.postgresql.org/docs/devel/static/nls-programmer.html#nls-guidelines
> Usually we just use two independent messages, and that's what I did.
Yep, makes sense. Thanks for the fix.
--
Fabien.
В списке pgsql-hackers по дате отправления: