Re: pgbench small bug fix
От | Fabien COELHO |
---|---|
Тема | Re: pgbench small bug fix |
Дата | |
Msg-id | alpine.DEB.2.10.1603091005231.25393@sto обсуждение исходный текст |
Ответ на | Re: pgbench small bug fix (Robert Haas <robertmhaas@gmail.com>) |
Ответы |
Re: pgbench small bug fix
|
Список | pgsql-hackers |
> On Wed, Jan 27, 2016 at 2:31 PM, Fabien COELHO <coelho@cri.ensmp.fr> wrote: >> - when a duration (-T) is specified, ensure that pgbench ends at that >> time (i.e. do not wait for a transaction beyond the end of the run). > > Every other place where doCustom() returns false is implemented as > return clientDone(...). I think this should probably do the same. Why not. clientDone() second arguments is totally ignored, I put true because it looks better. > I also think that we should probably store the end time someplace > instead of recomputing it in multiple places (this patch adds two such > places). Why not. Attached is a v4. -- Fabien.
В списке pgsql-hackers по дате отправления: