Re: [PATCH] add --progress option to pgbench (submission 3)
От | Fabien COELHO |
---|---|
Тема | Re: [PATCH] add --progress option to pgbench (submission 3) |
Дата | |
Msg-id | alpine.DEB.2.02.1307011238500.32704@localhost6.localdomain6 обсуждение исходный текст |
Ответ на | Re: [PATCH] add --progress option to pgbench (submission 3) (KONDO Mitsumasa <kondo.mitsumasa@lab.ntt.co.jp>) |
Ответы |
Re: [PATCH] add --progress option to pgbench (submission
3)
|
Список | pgsql-hackers |
Dear Mitsumasa, > I have small comments. I think that 'lat' is not generally abbreviation > of 'latency'. But I don't know good abbreviation. If you have any good > abbreviation, please send us revise version. I needed something short, because I may add a "lag" time as well under throttling. No better idea. > And, please fix under following code. It might be degrade by past your > patches. Done. I've also put the long option definition at its right place in the alphabetical order. > My comments are that's all. If you send latest patch, I'm going to set ready > for commiter. Please find attached version 6. > I also test your throttle patch. My impression of this patch is good, but it > does not necessary to execute with progress option. [...] I agree that it is not necessary. However for my use case it would be useful to have both throttling & progress at the same time, in particular to check the effect of other concurrent operations (eg. pg_dump, pg_basebackup) while a bench is running. -- Fabien.
В списке pgsql-hackers по дате отправления: