Re: Patch to add regression tests for SCHEMA

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: Patch to add regression tests for SCHEMA
Дата
Msg-id alpine.DEB.2.02.1306260439490.27845@localhost6.localdomain6
обсуждение исходный текст
Ответ на Re: Patch to add regression tests for SCHEMA  (Robins Tharakan <tharakan@gmail.com>)
Список pgsql-hackers
> Please find attached an updated patch with the said changes. I'll try to 
> update the other patches (if they pertain to this feedback) and update 
> on their respective threads (as well as on Commitfest).

Ok, this new version addresses my questions.

The patch works for me (nothing to compile, the added tests pass).

I recommend its inclusion as it tests corner cases especially about 
permissions and error conditions, some of which may have security 
implications if they were to fail some day. So this is a good thing.

The above remark applies to all systematic but not redundant regression 
tests submitted. If the overall test was to be deemed too long and slow 
for developers, I would suggest to have a two-tier system with basic and 
fast tests for devs and longer tests for the build farm.

-- 
Fabien.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Mark Wong
Дата:
Сообщение: Re: [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: [RFC] Minmax indexes