Re: [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT
От | Fabien COELHO |
---|---|
Тема | Re: [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT |
Дата | |
Msg-id | alpine.DEB.2.02.1306221856450.23902@localhost6.localdomain6 обсуждение исходный текст |
Ответ на | [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT (Cédric Villemain <cedric@2ndquadrant.com>) |
Список | pgsql-hackers |
Hello Cédric, > So maybe it is possible to rephrase this piece: > - <literal>AS IMPLICIT</> is a <productname>PostgreSQL</productname> > - extension, too. > + <literal>AS IMPLICIT</> and <literal>AS EXPLICIT</> are > + a <productname>PostgreSQL</productname> extension, too. Ok. > Back in 2012 Tom exposed arguments against it, or at least not a clear +1. > The patch add nothing but more explicit creation statement, it has gone > untouched for 2 years without interest so it is surely not something really > important for PostgreSQL users. Elegant is important:-) See my answer to Robert's objection. > * Coding review > Patch does not pass test: > ./check_keywords.pl gram.y ../../../src/include/parser/kwlist.h Oops! That is not elegant! > I had to update the unreserved keyword list in order to be able to build > postgresql. > ** Does it produce compiler warnings? don't build as is. Need patch update Indeed. > I flag it 'return with feedback', please update the patch so it builds. > Everything else is ok. Yep. -- Fabien.
В списке pgsql-hackers по дате отправления: