Re: pgbench --startup option

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: pgbench --startup option
Дата
Msg-id alpine.DEB.2.02.1306202013280.29119@localhost6.localdomain6
обсуждение исходный текст
Ответ на Re: pgbench --startup option  (Jeff Janes <jeff.janes@gmail.com>)
Список pgsql-hackers
> I've fixed a conflict, and I've removed extraneous semicolons from the C.
>
> I've left in the fixing of some existing bad indenting in the existing
> code, which is not strictly related to my change.

There are still unrelated changes : spacing on -c and -t options' help. 
The "pgindent" command is passed on the sources from time to time, so 
there should be no reason to change this in this commit.

The updated string for PQerrorMessage does not bring much, and the message 
does not seem an improvement. "Command failed with ERROR", indeed.
  Command failed with ERROR:  syntax error at or near ";"  LINE 1: set synchronous_commit=on;set synchronous_;

The preceding result seems bother simpler and fine:
  ERROR:  syntax error at or near ";"  LINE 1: set synchronous_commit=on;set synchronous_;

Otherwise I've tested the patch with one "set", two "set"s and a syntax 
error, and it worked as expected.

-- 
Fabien.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Fujii Masao
Дата:
Сообщение: Re: Fix pgstattuple/pgstatindex to use regclass-type as the argument
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)