Re: Patch to add regression tests for SCHEMA
От | Fabien COELHO |
---|---|
Тема | Re: Patch to add regression tests for SCHEMA |
Дата | |
Msg-id | alpine.DEB.2.02.1305080909330.2841@localhost6.localdomain6 обсуждение исходный текст |
Ответ на | Re: Patch to add regression tests for SCHEMA (Robins Tharakan <tharakan@gmail.com>) |
Ответы |
Re: Patch to add regression tests for SCHEMA
|
Список | pgsql-hackers |
Dear Robins, > Here is an updated patch that uses different schema / role names for > different tests (as per commitfest site feedback). Short review about this version of the patch: This patch work for me. This test is a good thing and allows schema to be thoroughly tested, including corner cases which must fail because of errors or permissions. Two remarks: - test 2 bis: why name 'pg_asdf'? why not 'pg_schema_sch<some number>' to be homogeneous with other tests? - test 3: why not WHERE schema_name='schema_sch3' instead of two negative comparisons? ISTM that if for some reason inthe future a new schema name is added, the test will fail. -- Fabien.
В списке pgsql-hackers по дате отправления: