Re: Cleanup shadows variable warnings, round 1

On 2026-Apr-21, David Rowley wrote:

> On Tue, 21 Apr 2026 at 19:02, Chao Li <li.evan.chao@gmail.com> wrote:
> > PFA v8 - rebased and fixed a few new occurrences.
> 
> Which of these are new to v19?  Can you separate those ones out? IMO,
> we should commit at least those, as those won't cause any backpatching
> pain.

I agree.  The others are v20 material.


Specifically about 0003 (v20 material for sure, as this is ancient
code), I don't like this patch very much.  I wonder if it would be
possible to do away with the idea of using these codeFragment things
without introducing a performance issue here.  Is that doable by turning
these macros into static functions?

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Puedes vivir sólo una vez, pero si lo haces bien, una vez es suficiente"