Re: Make copyObject work in C++
| От | Bertrand Drouvot |
|---|---|
| Тема | Re: Make copyObject work in C++ |
| Дата | |
| Msg-id | aeDIj2SBDl0EHZtb@bdtpg обсуждение |
| Ответ на | Re: Make copyObject work in C++ (Peter Eisentraut <peter@eisentraut.org>) |
| Список | pgsql-hackers |
Hi, On Thu, Apr 16, 2026 at 10:07:35AM +0200, Peter Eisentraut wrote: > On 14.04.26 15:10, Bertrand Drouvot wrote: > > Hi, > > > > On Thu, Apr 09, 2026 at 11:41:39AM +0000, Bertrand Drouvot wrote: > > > Hi, > > > > > > On Wed, Apr 01, 2026 at 07:54:07AM +0200, Peter Eisentraut wrote: > > > > > > > > Ok, I have committed the shown patch. > > > > > > d50c86e74375 added a comment mentionning that StaticAssertStmt is deprecated, so > > > we really need the one added in test_cplusplusext.cpp? > > > > Now that 66ad764c8d5 is in, the only remaining use of StaticAssertStmt() is in > > test_cplusplusext.cpp. What about the attached to get rid of it? > > This is a test module. Even if the construct is deprecated, we can still > test it. Right, but I was thinking that if we introduce a "pg_attribute_deprecated" macro (like discussed in [1] and [2]) and make use of it for StaticAssertStmt(), then this test module would generate Warnings. We can still come back to it should the above be implemented. [1]: https://postgr.es/m/CA%2BhUKGK2zuRevnNzCpVzLA7ieHnJoYPnDvgtWRcB4pVnOzchhQ%40mail.gmail.com [2]: https://postgr.es/m/aRGa87Ab0f3ItWRV@ip-10-97-1-34.eu-west-3.compute.internal Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления: