Re: Possible regression setting GUCs on \connect

On 4/27/23 21:43, Nathan Bossart wrote:
> I suspect the problem is that GUCArrayDelete() is using the wrong Datum:
> 
> diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
> index 9dd624b3ae..ee9f87e7f2 100644
> --- a/src/backend/utils/misc/guc.c
> +++ b/src/backend/utils/misc/guc.c
> @@ -6496,7 +6496,7 @@ GUCArrayDelete(ArrayType *array, ArrayType **usersetArray, const char *name)
>           {
>               newarray = construct_array_builtin(&d, 1, TEXTOID);
>               if (usersetArray)
> -                newUsersetArray = construct_array_builtin(&d, 1, BOOLOID);
> +                newUsersetArray = construct_array_builtin(&userSetDatum, 1, BOOLOID);
>           }
>   
>           index++;

That seems to work. The errors are now gone.

Thanks!
-David