Re: Improve UX of YUM/DNF download form

Поиск
Список
Период
Сортировка
От Jonathan S. Katz
Тема Re: Improve UX of YUM/DNF download form
Дата
Msg-id ae207206-5c8c-21d5-3eb8-6dfb75bca7e5@postgresql.org
обсуждение исходный текст
Ответ на Re: Improve UX of YUM/DNF download form  (Dave Page <dpage@pgadmin.org>)
Ответы Re: Improve UX of YUM/DNF download form
Список pgsql-www
On 6/9/20 7:58 AM, Dave Page wrote:
> So here's the updated patch following some discussion with Magnus:
>
> - Make the copyScript function more generic so it can be used elsewhere.
> - Don't include comments and blank lines in the copied text.
> - Move the css into main.css.
> - Add the actual install step to the Debian/Ubuntu instructions.
> - Improve naming of vars, classes, ids etc.
> - Ensure the copyScript function works fine with < > and so-on in the
> script.

That certainly changed a lot overnight ;)

LGTM. I don't have any additional comments on it, so I will give a +1.

Jonathan


Вложения

В списке pgsql-www по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: Improve UX of YUM/DNF download form
Следующее
От: Dave Page
Дата:
Сообщение: Re: Improve UX of YUM/DNF download form