Re: remove bits* types

On Mon, Mar 30, 2026 at 12:41:09PM -0400, Melanie Plageman wrote:
> On Thu, Mar 26, 2026 at 2:21 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> On Wed, Mar 25, 2026 at 05:27:34PM +0100, Peter Eisentraut wrote:
>> > I'm mildly in favor of removing them.  But it appears there is no consensus.
>>
>> Same here.  While it still doesn't look like anybody is totally opposed to
>> the idea, you are right that there is no consensus.
> 
> I really wish we would remove them. I want fewer confusing typedefs in
> the code -- not more. I'm quite sad that as of 1bd6f22f43ac1b we are
> now using them more widely (and publicly), and I feel that was done
> without consensus. It should just use a regular uint32 -- like other
> places we do this (e.g. scan_begin() amongst many others).

Thanks for the heads-up.  Here's a rebased patch.

With Melanie's note, there are at least 4 votes in favor of this patch
(Andres, me, Peter, and Melanie).  AFAICT Michael is +/-0, Álvaro and Tom
are -1 (or somewhere in the vicinity), and Robert seems ambivalent.  Hm...

-- 
nathan