On Tue, Mar 24, 2026 at 11:29:52PM -0400, Andres Freund wrote:
> On 2026-03-24 16:47:30 -0500, Nathan Bossart wrote:
>> + VacuumParams params_copy;
>
> I'd maybe not name it _copy, but params_local or params_table or such, as
> somehow it seems a bit odd to modify the copy. But I can't really explain why
> it feels odd.
params_local WFM.
> I wonder if more of the code in the function should be updated to use the
> copy, otherwise it seems like it could more easily happen that a part of the
> code not using the modified version is moved until after a modification, and
> the code author assumes the modifications now have taken effect.
Yeah, I was waffling on this. I updated the rest of the function to use
params_local instead.
--
nathan