Re: pgsql: Change default value of default_toast_compression to "lz4", when

On Thu, Mar 05, 2026 at 07:47:03AM +0900, Michael Paquier wrote:
> Hmm.  If you guys feel strongly about it, I'd be OK to revert.  Now
> there is a way to split the pie into two halves: we can still
> introduce DEFAULT_TOAST_COMPRESSION and use lz4 as default for the GUC
> if lz4 is included in the build but, leave the switch of --with-lz4 to
> --without-lz4 out of the equation.  This choice would leave the
> buildfarm in piece, and it still achieves the goal of enabling LZ4 in
> TOAST by default, as long as --without-lz4 is used.  As long as the
> latter is achieved, the point of the change would be made.


As I had the idea to press send too quickly, here's a reformulated
version.  ;)

We can still introduce DEFAULT_TOAST_COMPRESSION and use lz4 as
default for the GUC if lz4 is included in the build but leave the
switch of --with-lz4 to --without-lz4 out of the equation.  This
choice would leave the buildfarm in peace, and it still achieves the
goal of enabling LZ4 in TOAST by default, as long as --with-lz4 is
used.  As long as the latter goal is achieved, the point of the change
would be made, at least partially.
--
Michael