[HACKERS] ExecPrepareExprList and per-query context

Поиск
Список
Период
Сортировка
От Amit Langote
Тема [HACKERS] ExecPrepareExprList and per-query context
Дата
Msg-id aad31672-4983-d95d-d24e-6b42fee9b985@lab.ntt.co.jp
обсуждение исходный текст
Ответы Re: [HACKERS] ExecPrepareExprList and per-query context
Список pgsql-hackers
As of b8d7f053c5c, ExecPrepareExprList is (must be?) used instead of
ExecPrepareExpr when the caller wants to initialize expressions in a list,
for example, FormIndexDatum.  ExecPrepareExpr doesn't require the caller
to have switched to per-query context, because it itself will.  Same is
not however true for the new ExecPrepareExprList.  That means the List
node that it creates might be in a context that is not necessarily
per-query context, where it previously would be.  That breaks third-party
users of FormIndexDatum that rely on the list to have been created in
per-query context (pg_bulkload was broken by this).

Should ExecPrepareExprList also switch to estate->es_query_cxt?  Or maybe
ExecPrepareExpr could itself detect that passed-in node is a List and
create the list of ExprState nodes by itself.  I guess the reason to
separate list case is because ExecInitExpr() does not take Lists anymore.

Thanks,
Amit





В списке pgsql-hackers по дате отправления:

Предыдущее
От: Etsuro Fujita
Дата:
Сообщение: Re: [HACKERS] Declarative partitioning - another take
Следующее
От: Prakash Itnal
Дата:
Сообщение: [HACKERS] Performance issue with postgres9.6