Re: postgres_fdw fails to see that array type belongs to extension

Hi,

On 12/27/23 18:38, Tom Lane wrote:
> Hmm.  It seems odd that if an extension defines a type, the type is
> listed as a member of the extension but the array type is not.
> That makes it look like the array type is an externally-created
> thing that happens to depend on the extension, when it's actually
> part of the extension.  I'm surprised we've not run across other
> misbehaviors traceable to that.
Agreed.
> Of course, fixing it like that leads to needing to change the
> contents of pg_depend, so it wouldn't be back-patchable.  But it
> seems like the best way in the long run.

The attached patch just adds a 2nd dependency between the array type and 
the extension, using recordDependencyOnCurrentExtension(). It seems like 
that the other internal dependency on the element type must stay? If 
that seems reasonable I can add a test to modules/test_extensions. Can 
extensions in contrib use test extension in their own tests? It looks 
like postgres_fdw doesn't test any of the shippability logic.

-- 
David Geier
(ServiceNow)