Re: Miscellaneous message fixes

On Tue, Feb 10, 2026 at 02:37:52PM +0900, Kyotaro Horiguchi wrote:
> 0006:
> In extended_stats_funcs.c:
>> errmsg("could not find extended statistics object \"%s\".\"%s\"",
>>        quote_identifier(nspname),
>>        quote_identifier(stxname)));
>
> Since quote_identifier() already adds quoting when needed, adding
> "%s"."%s" in the format string results in double quoting. It would be
> better to use %s.%s instead.  I think quoting should be applied only
> when necessary here. I'm not sure we should use
> quote_qualified_identifier() instead.. (It's not used in the attached
> patch).
>
> There's a similar inconsistency.
>
>>    errmsg("could not clear extended statistics object \"%s\".\"%s\": incorrect relation \"%s\".\"%s\" specified",
>>           get_namespace_name(nspoid), stxname,
>>           relnspname, relname));
>
> In this part, the names are not passed through quote_identifier().  It
> would be better to unify this as well.

0006 relates to some of my recent business, so I'll go look and
address this part.  Thanks for the report.
--
Michael