Re: recovery.signal not cleaned up when both signal files are present

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: recovery.signal not cleaned up when both signal files are present
Дата
Msg-id aYpvppdC7yVtxviQ@paquier.xyz
обсуждение исходный текст
Ответ на Re: recovery.signal not cleaned up when both signal files are present  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: recovery.signal not cleaned up when both signal files are present
Список pgsql-hackers
On Tue, Feb 10, 2026 at 12:41:48AM +0900, Fujii Masao wrote:
> +1 on also cleaning up recovery.signal when both signal files are present.
>
> The documentation states that standby.signal takes precedence if both
> files exist,
> and this configuration is not described as unacceptable. So, it doesn't seem ok
> to prevent the server from starting in this case.

If both are present, startup should be OK and we should be in standby
mode.  Like reported, it really sounds like a problem to me to enforce
unnecessary TLI jumps because a recovery.signal is still around after
a standby promotion.  So, yes, removing it would be a good thing.
However I would argue against a backpatch as there is a risk of
slightly breaking existing recovery flows as well.  Doing such a
change like that on HEAD is OK.  This area of the code has always been
really sensitive to deal with in stable branches, particularly slight
changes in recovery behavior that could damage deployments (aka
monitoring) after a minor version upgrade.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления: