Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
Дата
Msg-id aYKU4AHnabERcy1j@paquier.xyz
обсуждение исходный текст
Ответ на Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers  (Nathan Bossart <nathandbossart@gmail.com>)
Ответы Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
Список pgsql-hackers
On Tue, Feb 03, 2026 at 09:34:33AM -0600, Nathan Bossart wrote:
> On Tue, Feb 03, 2026 at 09:45:49AM -0500, Tom Lane wrote:
>> I think we should reject this as useless code churn.  The parameter
>> was needed in the past and might be needed again in the future.
>> It's fairly common for other AtEOXact functions to take an isCommit
>> flag, so I don't find it surprising for these to have one.
>
> +1

+1.  Symmetry is usually relevant in the signature of these cleanup
functions.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления: