Re: pg_stat_statements: add missing tests for nesting_level

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: pg_stat_statements: add missing tests for nesting_level
Дата
Msg-id aXAg1zOSQmmdhazO@paquier.xyz
обсуждение исходный текст
Ответ на pg_stat_statements: add missing tests for nesting_level  (Sami Imseih <samimseih@gmail.com>)
Ответы Re: pg_stat_statements: add missing tests for nesting_level
Список pgsql-hackers
On Tue, Jan 20, 2026 at 06:08:14PM -0600, Sami Imseih wrote:
> While looking at pg_stat_statements nesting_level, I realized that there
> are missing nesting_level tests for pgss_planner and pgss_ExecutorFinish.
> That is, if you remove nesting_level++ and nesting_level-- in those 2 hooks,
> the tests will still succeed.
>
> For pgss_planner the nesting_level updates missing tests are the ones
> when track_planning is enabled.
>
> Attached is a quick patch to add coverage.

Confirmed these two deficiencies, nice catch.  If one does the same
removal of the nesting level calculation in other code paths like
pgss_ExecutorRun(), one get complaints.  Will see to get this addition
done.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления: