Re: [PATCH] Fix minor issues in astreamer_zstd.c

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] Fix minor issues in astreamer_zstd.c
Дата
Msg-id aWNR9iDqQThcqONC@paquier.xyz
обсуждение исходный текст
Ответ на Re: [PATCH] Fix minor issues in astreamer_zstd.c  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Sun, Jan 11, 2026 at 04:10:36PM +0900, Michael Paquier wrote:
> Could you demonstrate one or more examples when using these APIs
> proving that in some cases the current code can be a problem while the
> "fixed" code improves the situation, then extract test cases to be
> able to cover our future tracks?  This would take the shape of one or
> more regression tests to demonstrate individual problems.  If the
> three code paths touched here prove to be problematic, we would need
> three cases in total.  One other possibility would be to use a set of
> asserts to make sure that nobody uses these APIs in ways we don't
> expect them to.

See for example 3369a3b49b0b as one reference, that has fixed a bug in
the same area of the code.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления: