Re: Switch buffile.c/h to use pgoff_t

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Switch buffile.c/h to use pgoff_t
Дата
Msg-id aUuE-hAC1qPAnH75@paquier.xyz
обсуждение исходный текст
Ответ на Re: Switch buffile.c/h to use pgoff_t  (Chao Li <li.evan.chao@gmail.com>)
Ответы Re: Switch buffile.c/h to use pgoff_t
Список pgsql-hackers
On Tue, Dec 23, 2025 at 10:59:45AM +0800, Chao Li wrote:
> I’ve attached a small patch along these lines. It compiles without
> warnings, and "make check" passes on my side. What do you think?

I don't think it is right.  bytestowrite is not a file offset, and the
code has been using an int due to BufFile->nbytes.  This leads to a
more confusing result.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления: